This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
forked from boc-tothefuture/openhab-jruby
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
debounce
branch
4 times, most recently
from
December 18, 2022 00:27
ec136f2
to
592a658
Compare
I've updated the PR:
rule do
updated X
debounce for: 1.minute, leading: true # this supports extra parameters
run {}
end
# or
rule do
updated X
only_every :minute # this doesn't support the extra parameters
run {}
end I think this is ready to be reviewed now. |
jimtng
force-pushed
the
debounce
branch
8 times, most recently
from
December 20, 2022 10:39
25a7707
to
47b542b
Compare
Waiting on #152 |
ccutrer
suggested changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only add additional commits as this point, instead of force-pushing. Once it's all approved, we'll squash together as necessary, preserving the lead-up cleanups, but squashing any changes to debouncer itself together.
jimtng
force-pushed
the
debounce
branch
3 times, most recently
from
December 23, 2022 05:42
9bd9225
to
d54d97e
Compare
ccutrer
reviewed
Dec 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work
I squashed your last two commits together, changed the reset to be relative to now (instead of fixed at 1900) and fixed some minor formatting and grammar issues in docs. |
ccutrer
approved these changes
Dec 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #129 also boc-tothefuture#356