🐛 Fix bug in cancelCNOTs optimization
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a rare bug in the `cancelCNOTs` optimization that popped up in QMAP when a CNOT is followed by a SWAP and the SWAP's targets are not in sorted order.
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 44 44
Lines 7300 7300
=====================================
Hits 5999 5999
Misses 1301 1301
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rare bug in the
cancelCNOTsoptimization that popped up in QMAP when a CNOT is followed by a SWAP and the SWAP's targets are not in sorted order. This resulted in an incorrect substitution of CNOTs.