-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Trace Computation #628
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
- Coverage 91.6% 91.6% -0.1%
=======================================
Files 148 148
Lines 14736 14755 +19
Branches 2366 2369 +3
=======================================
+ Hits 13511 13522 +11
- Misses 1225 1233 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your work on this and for the clear code comments. These are highly appreciated!
I looked through all the changes here and you'll find my comments inline. Some are just minor suggestions that you can quickly incorporate. Some might take a little bit of work, but I think it shouldn't be too bad.
…el qubits are eliminated
…ble does not increase for non-eliminated lower-level qubits, but scales with the number of paths if lower-level qubits were eliminated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all your work on this. Especially, for writing thorough tests! ✅
I just pushed some finishing touches, which are mostly stylistic/minor. After CI is all green, this is good to go 🚀
Description
This PR introduces improvements for the trace computation:
Fixes #336
Checklist: