Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ providing a convenient CircuitInputType #661

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR provides a convenient type that summarizes the default circuit inputs to the load method.
Special care is taken that this type is only defined in type checking environments and does not require importing optional dependencies that might not be available at runtime (such as qiskit).

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Aug 6, 2024
@burgholzer burgholzer added usability Anything related to usability Core Anything related to the Core library and IR python Anything related to Python code labels Aug 6, 2024
@burgholzer burgholzer enabled auto-merge (squash) August 6, 2024 13:48
@burgholzer burgholzer added this to the MQT Core milestone Aug 6, 2024
@burgholzer burgholzer merged commit 768154b into main Aug 6, 2024
24 checks passed
@burgholzer burgholzer deleted the typing-improvement branch August 6, 2024 13:52
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.7%. Comparing base (4363502) to head (6a4b2c5).
Report is 128 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #661   +/-   ##
=====================================
  Coverage   91.7%   91.7%           
=====================================
  Files        148     148           
  Lines      14832   14832           
  Branches    2386    2386           
=====================================
  Hits       13603   13603           
  Misses      1229    1229           
Flag Coverage Δ *Carryforward flag
cpp 91.4% <ø> (ø) Carriedforward from 4363502
python 99.7% <100.0%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/core/load.py 100.0% <100.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR python Anything related to Python code usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant