-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸♻️ convenience methods and updates for DD functionality #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
- Coverage 92.1% 92.1% -0.1%
=======================================
Files 125 125
Lines 13775 13791 +16
Branches 2160 2164 +4
=======================================
+ Hits 12690 12703 +13
- Misses 1085 1088 +3
|
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
7860cb8
to
82c21e1
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Renamed the `simulate` function to `sample` for consistency and clarity. Implemented virtual SWAP gate execution by altering qubit permutations directly. Updated function signatures and internal logic for applying unitary, measurement, and reset operations, supporting the new SWAP handling. Removed redundant permutation management in function calls and streamlined permutation updates. Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
4 tasks
burgholzer
added a commit
that referenced
this pull request
Nov 28, 2024
## Description This is a direct follow-up to #674 and adds one more convenience routine that avoids users having to perform reference counting on their own. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <burgholzer@me.com>
4 tasks
burgholzer
added a commit
to cda-tum/mqt-qcec
that referenced
this pull request
Jan 8, 2025
## Description This PR updates the MQT Core version used in QCEC to the latest version. This includes changes from cda-tum/mqt-core#674 and cda-tum/mqt-core#764. SWAP eliding is now performed explicitly in QCEC instead of implicitly in the `getDD` method of MQT Core. Furthermore, states generated by the DD package now have their ref count increased by default, which required subtle changes to the ref counting scheme. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Anything related to C++ code
DD
Anything related to the DD package
enhancement
New feature or request
minor
Minor version update
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes aimed at improving code efficiency and readability across the DD package.
Utility (functions):
Operations.hpp
for applying unitary operations, measurements, resets, and classically controlled operations on quantum states.Code simplification:
getDD
function by removing redundant checks and improving the handling of permutations.sample
method was introduced as a shortcut for simply sampling from the output distribution of a circuit.These changes collectively enhance the maintainability and performance of the codebase.
They will require changes in consuming libraries. Especially mqt-ddsim, mqt-qcec, and mqt-ddvis. However, these changes should simplify the overall code in these libraries.
Checklist: