Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 drop Python 3.8 support #684

Merged
merged 2 commits into from
Sep 6, 2024
Merged

🔥 drop Python 3.8 support #684

merged 2 commits into from
Sep 6, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 5, 2024

Description

Python 3.8 will reach end of live in October 2024.
Qiskit is already issuing deprecation warnings since a couple of releases when using it on Python 3.8.
This PR officially drops support for Python 3.8 in mqt-core.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file Core Anything related to the Core library and IR python Anything related to Python code labels Sep 5, 2024
@burgholzer burgholzer added this to the MQT Core milestone Sep 5, 2024
@burgholzer burgholzer force-pushed the drop-python-38-support branch from 5018503 to a5165f7 Compare September 5, 2024 15:47
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.0%. Comparing base (11f7ab0) to head (77394c7).
Report is 103 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #684     +/-   ##
=======================================
- Coverage   87.1%   87.0%   -0.1%     
=======================================
  Files        125     125             
  Lines      13782   13781      -1     
  Branches    2164    2164             
=======================================
- Hits       12008   11995     -13     
- Misses      1774    1786     +12     
Flag Coverage Δ
cpp 86.6% <ø> (-0.1%) ⬇️
python 99.7% <100.0%> (ø)
Files with missing lines Coverage Δ
src/mqt/core/plugins/qiskit.py 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the drop-python-38-support branch from a5165f7 to fbfdbe1 Compare September 6, 2024 17:30
@burgholzer burgholzer enabled auto-merge (squash) September 6, 2024 20:28
@burgholzer burgholzer merged commit 738d181 into main Sep 6, 2024
33 checks passed
@burgholzer burgholzer deleted the drop-python-38-support branch September 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR dependencies Pull requests that update a dependency file python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant