Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bindings update #7

Merged
merged 5 commits into from
Jun 4, 2021
Merged

Python bindings update #7

merged 5 commits into from
Jun 4, 2021

Conversation

burgholzer
Copy link
Member

πŸ‘½ update Qiskit QuantumCircuit bindings to remove deprecation warning
✨ new bindings for Qiskit QasmQobjExperiment objects

Signed-off-by: Lukas Burgholzer lukas.burgholzer@jku.at

πŸ‘½ update Qiskit QuantumCircuit bindings to remove deprecation warning
✨ new bindings for Qiskit QasmQobjExperiment objects

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #7 (946693a) into master (a75d600) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #7     +/-   ##
========================================
- Coverage    73.5%   73.4%   -0.2%     
========================================
  Files          37      37             
  Lines        5134    5134             
========================================
- Hits         3778    3772      -6     
- Misses       1356    1362      +6     
Impacted Files Coverage Ξ”
test/algorithms/test_random_clifford.cpp 100.0% <100.0%> (ΓΈ)
src/algorithms/RandomCliffordCircuit.cpp 93.5% <0.0%> (-3.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a75d600...946693a. Read the comment docs.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@hillmich hillmich self-requested a review June 2, 2021 11:56
jkq/qfr/qiskit/QasmQobjExperiment.hpp Outdated Show resolved Hide resolved
jkq/qfr/qiskit/QasmQobjExperiment.hpp Show resolved Hide resolved
jkq/qfr/qiskit/QuantumCircuit.hpp Outdated Show resolved Hide resolved
@burgholzer burgholzer self-assigned this Jun 2, 2021
@burgholzer burgholzer added the enhancement New feature or request label Jun 2, 2021
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Copy link
Collaborator

@hillmich hillmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works in DDSIM

@burgholzer burgholzer merged commit c98ac8e into master Jun 4, 2021
@burgholzer burgholzer deleted the new-qiskit-import branch June 4, 2021 07:56
burgholzer added a commit that referenced this pull request Jun 2, 2023
🚸 user-defined literals `_pc` and `_nc` for positive/negative controls
🚸 convenience functions for `makeGateDD`
πŸ› also consider negative controls in Toffoli hash
πŸš‘οΈ circumvent gcc's troubles of compiling the package in reasonable time
βœ… added test for negative control
πŸ“ updated README.md

Co-authored-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
burgholzer pushed a commit that referenced this pull request Jun 2, 2023
Bumps [extern/googletest](https://github.com/google/googletest) from `8b521aa` to `86add13`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@8b521aa...86add13)

---
updated-dependencies:
- dependency-name: extern/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants