🐛 fix endianness in DCX and XX_minus_YY gate matrix definition #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has been brought up as in cda-tum/mqt-qcec/issues/489.
Turns out the endianness of the DCX gate matrix was wrong and this has not been detected because the tests where multiplying the gates of the definition for verification purposes in the wrong order.
After adjusting the tests, another incorrect endianness result popped up for the
xx_minus_yy
gate.Both issues have now been fixed.
Checklist: