-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ switch to mqt-core
Python package
#355
Conversation
a8dba9f
to
44112aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
- Coverage 96.4% 96.2% -0.2%
=======================================
Files 34 34
Lines 1753 1749 -4
Branches 215 215
=======================================
- Hits 1690 1684 -6
- Misses 63 65 +2
|
c870020
to
b9de1de
Compare
Cpp-Linter Report
|
## Description This PR updates the mqt-core submodule and brings in some further advancements from #355. Specifically, it switches to using `FetchContent` for obtaining `mqt-core`. Per default, it is pointed to the vendored submodule via an overridable CMake variable. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <burgholzer@me.com>
6cf3f5f
to
b54600d
Compare
0fea3ca
to
9992718
Compare
4f49ee5
to
0621d80
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
e94a1dd
to
b555c9f
Compare
Closing in favor of #432 |
## Description This is an alternative to #355 and marks the final transition to the `mqt-core` Python package. See #355 and #352 for some history on this topic. In addition to directly using the MQT Core Python package, this PR makes Qiskit an optional dependency of MQT QCEC. All core functionality is now covered MQT-internally. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
Description
This PR is a best-of extraction from #352 and switches the project to use the newly developed
mqt-core
Python package.Due to the use of
FetchContent
, any Python package build will only require themqt-core
package as a build and runtime dependency and won't have to rely on the git submodule (or a fetched version of mqt-core) any more.Any regular C++ build will use the
FetchContent
CMake module. This logic could probably be improved a little bit so that the submodule is used whenever it has been properly cloned.The change brings a range of advantages:
load
function ofmqt-core
that allows to load any supported circuit format as input and has better handling for QiskitQuantumCircuit
objects.Checklist: