Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️👽 update to latest MQT Core version #534

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

burgholzer
Copy link
Member

Description

This PR updates the MQT Core version used in QCEC to the latest version. This includes changes from cda-tum/mqt-core#798.
Algorithms are now constructed slightly differently and some of the methods now take references instead of pointers.

This PR also fixes one compiler warning related to a potential uniniatialized usage in the equivalence checking manager.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Jan 12, 2025
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code code quality Anything related to code quality and code style. labels Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.5%. Comparing base (c3fbfc2) to head (ad514e6).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #534     +/-   ##
=======================================
- Coverage   95.5%   95.5%   -0.1%     
=======================================
  Files         40      40             
  Lines       1838    1840      +2     
  Branches     223     223             
=======================================
+ Hits        1757    1758      +1     
- Misses        81      82      +1     
Flag Coverage Δ
cpp 96.0% <100.0%> (-0.1%) ⬇️
python 93.7% <ø> (ø)
Files with missing lines Coverage Δ
include/EquivalenceCheckingManager.hpp 100.0% <100.0%> (ø)
include/checker/dd/TaskManager.hpp 97.2% <100.0%> (ø)
src/checker/dd/simulation/StateGenerator.cpp 94.9% <100.0%> (ø)

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 6c0788e into main Jan 12, 2025
66 checks passed
@burgholzer burgholzer deleted the refactor-based-on-mqt-core-changes branch January 12, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Anything related to code quality and code style. dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant