-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Sub-Architectures #106
✨ Sub-Architectures #106
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
+ Coverage 91.4% 91.8% +0.4%
=======================================
Files 23 24 +1
Lines 1875 2095 +220
Branches 414 414
=======================================
+ Hits 1714 1925 +211
- Misses 161 170 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request introduces 1 alert when merging c4d080d into 1cf5adc - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really minor comments. Overall, I am super happy with this PR. Really looks clean! Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The only blocker left is the arXiv submission. Then this should be ready to merge.
Also fixed the reference in rtd to point to the ArXiv PDF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to the new paper is still missing in the README. Other than that, we are good to go once all tests pass.
Signed-off-by: burgholzer <burgholzer@me.com>
11ae8fa
to
fd94658
Compare
Forgot to run mypy.
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
# Conflicts: # docs/source/Library.rst
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Added functionality for computing sub-architectures for qubit mapping based on https://arxiv.org/abs/2210.09321.