Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Sub-Architectures #106

Merged
merged 85 commits into from
Oct 21, 2022
Merged

✨ Sub-Architectures #106

merged 85 commits into from
Oct 21, 2022

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Sep 7, 2022

Added functionality for computing sub-architectures for qubit mapping based on https://arxiv.org/abs/2210.09321.

@pehamTom pehamTom added feature New feature or request python Anything related to Python code labels Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Attention: Patch coverage is 95.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.8%. Comparing base (98486ca) to head (6720fb6).
Report is 826 commits behind head on main.

Files with missing lines Patch % Lines
mqt/qmap/subarchitectures.py 95.8% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #106     +/-   ##
=======================================
+ Coverage   91.4%   91.8%   +0.4%     
=======================================
  Files         23      24      +1     
  Lines       1875    2095    +220     
  Branches     414     414             
=======================================
+ Hits        1714    1925    +211     
- Misses       161     170      +9     
Flag Coverage Δ
cpp 91.2% <ø> (ø)
python 94.7% <95.9%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2022

This pull request introduces 1 alert when merging c4d080d into 1cf5adc - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really minor comments. Overall, I am super happy with this PR. Really looks clean! Thanks a lot!

docs/source/refs.bib Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
mqt/qmap/subarchitectures.py Outdated Show resolved Hide resolved
docs/source/library/Subarchitectures.rst Outdated Show resolved Hide resolved
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The only blocker left is the arXiv submission. Then this should be ready to merge.

pehamTom and others added 2 commits October 19, 2022 10:57
Also fixed the reference in rtd to point to the ArXiv PDF.
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to the new paper is still missing in the README. Other than that, we are good to go once all tests pass.

@burgholzer burgholzer merged commit 65b2f27 into main Oct 21, 2022
@burgholzer burgholzer deleted the subarchitectures branch October 21, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request python Anything related to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants