Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Streamline Z3 Configuration #112

Merged
merged 99 commits into from
Sep 14, 2022
Merged

👷 Streamline Z3 Configuration #112

merged 99 commits into from
Sep 14, 2022

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 8, 2022

QMAP's CI complexity mainly stems from some legacy best practises and the huge burden of getting Z3 to work properly in a CI environment. This is why I created https://github.com/cda-tum/setup-z3. An action that properly sets up a version of Z3 by cloning the respective binary release and providing the root directory as an environment variable.
As a result, a consistent version of Z3 can now be used throughout all jobs and many jobs could be simplified again to just use a GitHub build matrix.

This PR also significantly improves the capabilities of the FindZ3.cmake script that can now find an appropriate Z3 version in more cases than ever. It can even pick-up Z3 from the virtual environment if it is installed from pip.
Furthermore, it now determines a proper version even when cross-compiling or when multiple Z3 installations are present.

Last but not least, a wheel repair step is introduced for Windows wheels which should increase the portability of the produced Python package.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added the continuous integration Anything related to the CI setup label Sep 8, 2022
@burgholzer burgholzer self-assigned this Sep 8, 2022
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #112 (f9f2bbe) into main (62d27db) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #112   +/-   ##
=====================================
  Coverage   91.2%   91.2%           
=====================================
  Files         20      20           
  Lines       1731    1731           
  Branches     414     414           
=====================================
  Hits        1580    1580           
  Misses       151     151           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

burgholzer and others added 23 commits September 9, 2022 00:38
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
this will, most likely break cross-compilation

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer marked this pull request as ready for review September 14, 2022 16:09
@burgholzer burgholzer changed the title ⚗️ Experiment with Improving CI Setup 👷 Streamline CI Setup Sep 14, 2022
@burgholzer burgholzer changed the title 👷 Streamline CI Setup 👷 Streamline Z3 Configuration Sep 14, 2022
@burgholzer burgholzer merged commit 2498c72 into main Sep 14, 2022
@burgholzer burgholzer deleted the z3-ci branch September 14, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant