Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fixup codecov flag config #155

Merged
merged 2 commits into from
Oct 20, 2022
Merged

🔧 Fixup codecov flag config #155

merged 2 commits into from
Oct 20, 2022

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Oct 20, 2022

Description

It turns out that #154 did not properly configure the coverage flags as some header and source files got lost.
This PR tries to fix that and also unifies some of the configuration settings.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass. (C++ coverage is only lower due to the correct configuration)
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added bug Something isn't working continuous integration Anything related to the CI setup labels Oct 20, 2022
@burgholzer burgholzer self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #155 (28d62d6) into main (7dc2a5c) will decrease coverage by 2.5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #155     +/-   ##
=======================================
- Coverage   93.9%   91.4%   -2.6%     
=======================================
  Files         16      23      +7     
  Lines       1062    1875    +813     
  Branches     241     414    +173     
=======================================
+ Hits         998    1714    +716     
- Misses        64     161     +97     
Flag Coverage Δ
cpp 91.2% <ø> (-2.9%) ⬇️
python 93.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Architecture.hpp 87.0% <0.0%> (ø)
src/Architecture.cpp 95.2% <0.0%> (ø)
include/Mapper.hpp 58.0% <0.0%> (ø)
include/utils.hpp 83.3% <0.0%> (ø)
include/MappingResults.hpp 64.5% <0.0%> (ø)
src/utils.cpp 89.2% <0.0%> (ø)
src/Mapper.cpp 93.1% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer changed the title 🔧 Fixup codecov flag config 🔧 Fixup codecov flag config Oct 20, 2022
@burgholzer burgholzer merged commit 98486ca into main Oct 20, 2022
@burgholzer burgholzer deleted the codecov-fixup branch October 20, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working continuous integration Anything related to the CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant