Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 adapt for Qiskit 0.46.0 #422

Merged
merged 3 commits into from
Feb 5, 2024
Merged

🚨 adapt for Qiskit 0.46.0 #422

merged 3 commits into from
Feb 5, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR updates the project to work with the latest Qiskit version. In turn, and in preparation for the 1.0 release of Qiskit, it adapts the project to the expected removals already. While this raises the minimum supported Qiskit version to 0.46.0, it should make switching to 1.0 as easy as possible.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code code quality Anything related to code quality and code style. labels Feb 5, 2024
@burgholzer burgholzer self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (414accd) 92.8% compared to head (ab0a6e8) 92.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #422     +/-   ##
=======================================
- Coverage   92.8%   92.7%   -0.1%     
=======================================
  Files         48      48             
  Lines       5364    5340     -24     
  Branches     911     911             
=======================================
- Hits        4979    4952     -27     
- Misses       385     388      +3     
Flag Coverage Δ *Carryforward flag
cpp 92.5% <ø> (ø) Carriedforward from d382e64
python 94.4% <85.7%> (-1.0%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/mqt/qmap/load_calibration.py 100.0% <100.0%> (ø)
src/mqt/qmap/subarchitectures.py 95.5% <100.0%> (-0.9%) ⬇️
src/mqt/qmap/qiskit/backend.py 92.1% <50.0%> (-4.7%) ⬇️

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit 752a66a into main Feb 5, 2024
27 of 29 checks passed
@burgholzer burgholzer deleted the adapt-to-qiskit-0.46.0 branch February 5, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. dependencies Pull requests that update a dependency file python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant