Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support for Qiskit 1.0 #427

Merged
merged 7 commits into from
Feb 21, 2024
Merged

✨ Support for Qiskit 1.0 #427

merged 7 commits into from
Feb 21, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR marks the official support of Qiskit 1.0 in mqt-qmap.

In order to avoid all kinds of ugly compatibility hacks, this PR also changes the minimum required Qiskit version to 1.0.
Since Qiskit has devoted themselves to following semantic versioning from now on out, this hopefully means fewer compatibility changes in the future.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added feature New feature or request dependencies Pull requests that update a dependency file python Anything related to Python code minor Changes leading to a minor version increase labels Feb 21, 2024
@burgholzer burgholzer self-assigned this Feb 21, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a76138) 89.7% compared to head (738dcd9) 89.7%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #427   +/-   ##
=====================================
  Coverage   89.7%   89.7%           
=====================================
  Files         61      61           
  Lines       6341    6361   +20     
  Branches    1008    1008           
=====================================
+ Hits        5693    5712   +19     
- Misses       648     649    +1     
Flag Coverage Δ
cpp 89.3% <ø> (-0.1%) ⬇️
python 94.9% <100.0%> (+0.4%) ⬆️
Files Coverage Δ
src/mqt/qmap/load_calibration.py 100.0% <100.0%> (ø)
src/mqt/qmap/qiskit/backend.py 96.3% <100.0%> (+4.2%) ⬆️

... and 3 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit f4b8ba0 into main Feb 21, 2024
35 checks passed
@burgholzer burgholzer deleted the qiskit-1.0 branch February 21, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature or request minor Changes leading to a minor version increase python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant