Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 smaller Python wheels #457

Merged
merged 1 commit into from
May 24, 2024
Merged

📦 smaller Python wheels #457

merged 1 commit into from
May 24, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR reduces the binary wheel size for the project by only installing the specific python bindings CMake component.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this May 24, 2024
@burgholzer burgholzer added python Anything related to Python code packaging Anything related to Python packaging labels May 24, 2024
@burgholzer burgholzer enabled auto-merge (squash) May 24, 2024 12:03
@burgholzer burgholzer merged commit 0c28314 into main May 24, 2024
33 checks passed
@burgholzer burgholzer deleted the smaller-wheels branch May 24, 2024 12:27
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.4%. Comparing base (801e000) to head (ececc89).
Report is 86 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #457   +/-   ##
=====================================
  Coverage   90.4%   90.4%           
=====================================
  Files         68      68           
  Lines       7852    7852           
  Branches    1277    1277           
=====================================
  Hits        7102    7102           
  Misses       750     750           
Flag Coverage Δ
cpp 90.0% <ø> (ø)
python 95.9% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant