Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add measurements to mapped circuit #50

Merged
merged 22 commits into from
May 3, 2022
Merged

✨ Add measurements to mapped circuit #50

merged 22 commits into from
May 3, 2022

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented May 2, 2022

This PR adds the functionality to include measurements in mapped circuits according to the stored output permutation.
Furthermore, the qubit registers of the mapped circuit are now unified into a single register, similar to how this is handled in Qiskit.

It also fixes some smaller bugs:

  • 🐛 fixed issue where output results in exact mapper were not instantiated correctly
  • 🐛 fixed the computation of the IO mapping in both mappers which is required for correct dumping

burgholzer added 2 commits May 2, 2022 14:05
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added the feature New feature or request label May 2, 2022
@burgholzer burgholzer self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #50 (d5fffa3) into main (f557687) will increase coverage by 0.4%.
The diff coverage is 95.6%.

@@           Coverage Diff           @@
##            main     #50     +/-   ##
=======================================
+ Coverage   88.2%   88.7%   +0.4%     
=======================================
  Files         21      22      +1     
  Lines       1613    1660     +47     
=======================================
+ Hits        1424    1473     +49     
+ Misses       189     187      -2     
Impacted Files Coverage Δ
include/Mapper.hpp 51.6% <ø> (ø)
src/Mapper.cpp 94.0% <87.5%> (-1.7%) ⬇️
src/exact/ExactMapper.cpp 97.8% <100.0%> (+1.2%) ⬆️
src/heuristic/HeuristicMapper.cpp 94.0% <100.0%> (+<0.1%) ⬆️
include/exact/ExactMapper.hpp 100.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f557687...d5fffa3. Read the comment docs.

burgholzer and others added 20 commits May 2, 2022 15:09
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer enabled auto-merge (squash) May 3, 2022 08:27
@burgholzer burgholzer merged commit eb0d896 into main May 3, 2022
@burgholzer burgholzer deleted the measurements branch May 15, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant