Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️🪝 update pre-commit config #502

Merged
merged 7 commits into from
Aug 9, 2024
Merged

⬆️🪝 update pre-commit config #502

merged 7 commits into from
Aug 9, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR adds schema validation to the pre-commit hooks. In addition, it also replaces codespell with crates-ci/typos and fix all newly brought up typos.
Finally, the PR runs pre-commit autoupdate.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file continuous integration Anything related to the CI setup code quality Anything related to code quality and code style. labels Aug 9, 2024
@burgholzer burgholzer self-assigned this Aug 9, 2024
@burgholzer burgholzer enabled auto-merge (squash) August 9, 2024 08:33
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.5%. Comparing base (0a0f568) to head (ae36335).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
src/na/NAGraphAlgorithms.cpp 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #502   +/-   ##
=====================================
  Coverage   90.5%   90.5%           
=====================================
  Files         86      86           
  Lines      10028   10022    -6     
  Branches    1711    1710    -1     
=====================================
- Hits        9078    9075    -3     
+ Misses       950     947    -3     
Flag Coverage Δ
cpp 90.2% <88.8%> (+<0.1%) ⬆️
python 95.9% <100.0%> (ø)
Files with missing lines Coverage Δ
include/Architecture.hpp 88.4% <ø> (ø)
include/utils.hpp 81.8% <ø> (ø)
src/Architecture.cpp 96.6% <100.0%> (-0.1%) ⬇️
src/mqt/qmap/subarchitectures.py 95.5% <100.0%> (ø)
src/utils.cpp 93.2% <ø> (ø)
src/na/NAGraphAlgorithms.cpp 95.2% <75.0%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit a3c9307 into main Aug 9, 2024
33 of 34 checks passed
@burgholzer burgholzer deleted the pre-commit-checks branch August 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant