Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encodings #61

Merged
merged 4 commits into from
May 15, 2022
Merged

Fix encodings #61

merged 4 commits into from
May 15, 2022

Conversation

burgholzer
Copy link
Member

This (hopefully) is the last PR that tries to fix the custom atMostOne and exactlyOne encodings.
TBH, I am really surprised these ever worked.

Fixes #58

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer added the bug Something isn't working label May 15, 2022
@burgholzer burgholzer self-assigned this May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #61 (29051cf) into main (aa7a2d4) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main     #61   +/-   ##
=====================================
  Coverage   89.9%   89.9%           
=====================================
  Files         22      22           
  Lines       1716    1719    +3     
=====================================
+ Hits        1543    1546    +3     
  Misses       173     173           
Impacted Files Coverage Δ
src/Encodings.cpp 96.2% <ø> (ø)
include/configuration/AvailableArchitecture.hpp 81.4% <100.0%> (+2.3%) ⬆️
src/exact/ExactMapper.cpp 98.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7a2d4...29051cf. Read the comment docs.

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer merged commit 37ce12f into main May 15, 2022
@burgholzer burgholzer deleted the fix_encodings branch May 15, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom encodings not working
1 participant