Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rigetti agave and aspen #66

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

lucasberent
Copy link
Contributor

Adds Rigetti architectures Agave and Aspen

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #66 (358ee56) into main (dea2a65) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main     #66   +/-   ##
=====================================
  Coverage   89.9%   89.9%           
=====================================
  Files         22      22           
  Lines       1719    1725    +6     
=====================================
+ Hits        1546    1552    +6     
  Misses       173     173           
Impacted Files Coverage Δ
include/configuration/AvailableArchitecture.hpp 84.8% <100.0%> (+3.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea2a65...358ee56. Read the comment docs.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM. many thanks 👍🏼 . A couple of small requests can be found below.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@lucasberent lucasberent requested a review from burgholzer June 3, 2022 13:46
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgholzer burgholzer merged commit 09a9e51 into cda-tum:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants