Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update CodeQL configuration #75

Merged
merged 21 commits into from
Sep 8, 2022
Merged

🔧 Update CodeQL configuration #75

merged 21 commits into from
Sep 8, 2022

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 7, 2022

This PR updates the GitHub CodeQL configuration in anticipation of the deprecation of LGTM.
Most importantly, it adds further checks and a custom build step for C++ to also cover the Python bindings.

These additional checks have revealed a couple of easy to fix warnings that have subsequently been fixed.
As a pleasant side effect, the Python tests now work irrespective of the directory they are executed in.
A corresponding nox session tests (similar to lint, and docs) is added to the project.

Conveniently run the Python tests via

nox -rs tests

Use nox -rs tests-3.9 to run the tests on Python 3.9 only.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added the github_actions Pull requests that update GitHub Actions code label Sep 7, 2022
@burgholzer burgholzer self-assigned this Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #75 (973da7b) into main (58ee277) will not change coverage.
The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main     #75   +/-   ##
=====================================
  Coverage   91.2%   91.2%           
=====================================
  Files         29      29           
  Lines       1825    1825           
=====================================
  Hits        1666    1666           
  Misses       159     159           
Impacted Files Coverage Δ
include/core/syrec/grammar.hpp 95.8% <ø> (ø)
include/core/syrec/module.hpp 90.9% <ø> (ø)
include/core/syrec/statement.hpp 95.3% <ø> (ø)
src/core/syrec/parser.cpp 86.4% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@burgholzer burgholzer added the continuous integration Anything related to the CI setup label Sep 7, 2022
burgholzer and others added 19 commits September 7, 2022 15:23
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
especially, proper file management

Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
@burgholzer burgholzer merged commit 10dc664 into main Sep 8, 2022
@burgholzer burgholzer deleted the codeql-update branch September 8, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant