Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullrequest comments #11

Closed
tomasbjerre opened this issue Jul 27, 2016 · 4 comments
Closed

Pullrequest comments #11

tomasbjerre opened this issue Jul 27, 2016 · 4 comments
Assignees
Milestone

Comments

@tomasbjerre
Copy link
Contributor

I need POST and GET and for individual comments I need DELETE.

I can work on this one.

@cdancy cdancy added this to the v0.0.5 milestone Jul 27, 2016
@cdancy cdancy self-assigned this Jul 27, 2016
@cdancy
Copy link
Owner

cdancy commented Jul 27, 2016

@tomasbjerre thanks! I was actually going to tackle this next as I have need to post comments. Ping me if you have any questions about how to do so. This library is modeled around a typical jclouds project so if you don't have any experience/knowledge coding for such a thing it can be a bit daunting until you get used to how everything is wired together.

@tomasbjerre
Copy link
Contributor Author

I started fiddling with this a bit. How do you run the test cases? I do _gradlew build_ and I get zero tests run. According to test report in _/build/reports/tests/index.html_.

@cdancy
Copy link
Owner

cdancy commented Jul 27, 2016

There are 2 types of tests/tasks: Mock (mockTest) and Integration (integTest). The former is to model the interaction and ensure the library works as expected while the latter ensures the interaction with bitbucket works as expected. To run either from the command line: ./gradlew mockTest or ./gradlew integTest which depends on mock tests running successfully.

It should be noted that for integration tests I make no attempt at setting up a bitbucket server or initing a repo/project/branch/etc, this needs to be done. Open up any of the "Integration*.java" files and you can see how I've hard-coded names of previously existing projects/repos/etc near the top.

Furthermore there are a couple properties testBitbucketEndpoint and testBitbucketCredential which the integration tests will use to connect to a given bitbucket instance. If you just want to test a single integration test pop open the build.gradle file, navigate to integTest, and hard-code in what you need for the moment.

cdancy added a commit that referenced this issue Aug 31, 2016
PR-#11: Created CommentsApi with endpoints 'get', 'comment', and 'cre…
cdancy added a commit that referenced this issue Aug 31, 2016
PR-#11: CommentsApi gained endpoint 'delete'.
@cdancy
Copy link
Owner

cdancy commented Aug 31, 2016

Closing issue as the CommentsApi has been implemented with PR's #17 and #16. Endpoints comment, createComment, get, and delete have all been coded. Functionality can be found in version 0.0.10 of this library.

@cdancy cdancy closed this as completed Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants