Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expose modules for logging #157

Merged
merged 3 commits into from
Aug 31, 2018

Conversation

richabindra
Copy link
Contributor

This PR addresses Issue #156. A module option is added to the builder, so logging can be added at the application level if needed.

@richabindra
Copy link
Contributor Author

richabindra commented Aug 29, 2018

@cdancy - I copied the logging example from jenkins-rest wiki and created a Wiki for bitbucket-rest. I am not sure whether it needs to be added or not. Could you please advise?

@cdancy
Copy link
Owner

cdancy commented Aug 29, 2018

Code LGTM. Yeah not sure if you can just clone the wiki over or if it will come with the branch. @martinda do you remember how you did this?

@cdancy cdancy added this to the v2.2.1 milestone Aug 29, 2018
@martinda
Copy link
Contributor

The documentation is on a different upstream, in this case it would be https://github.com/cdancy/bitbucket-rest.wiki.git and it is not possible to use pull-requests, so for jenkins-rest I had to push directly to the cdancy user space. I had to push to master directly, and correct mistakes by pushing fixes.

@martinda
Copy link
Contributor

@richabindra Thank you for providing the wiki and the code. Regarding the Wiki, it will need to be updated after this PR makes it to a release in order for the examples to use the right version numbers. Also I suggest you run all the code in the examples to make sure they are accurate.

@richabindra
Copy link
Contributor Author

richabindra commented Aug 30, 2018

Ran the code in the examples as @martinda suggested. The example was tested by setting the version of bitbucket-rest to 2.2.1-SNAPSHOT locally, and is published with version set to 2.2.1.

@cdancy cdancy merged commit 64aabbb into cdancy:master Aug 31, 2018
@cdancy
Copy link
Owner

cdancy commented Aug 31, 2018

@richabindra thanks for the PR! I can kick an new patch release ASAP if you want one. Just let me know.

@cdancy cdancy self-assigned this Aug 31, 2018
@richabindra
Copy link
Contributor Author

@cdancy - yes, a new patch release would be great! thank you :)

@cdancy
Copy link
Owner

cdancy commented Aug 31, 2018

@richabindra version 2.2.1 is now available.

@richabindra
Copy link
Contributor Author

@cdancy - thank you.. appreciate the quick response :)

@cdancy
Copy link
Owner

cdancy commented Aug 31, 2018

@richabindra you're welcome and no problem.

@richabindra
Copy link
Contributor Author

@cdancy - I tried pushing wiki page directly to your repository, but I am getting permission denied (obviously, but I just wanted to try). How do you want to go about moving wiki to your space?

@cdancy
Copy link
Owner

cdancy commented Aug 31, 2018

@richabindra try again. I just opened things up to allow anyone to edit.

@richabindra
Copy link
Contributor Author

@cdancy - done. thank you. I have added logging page to wiki. Please review and let me know if there is anything that needs to be fixed..

@cdancy
Copy link
Owner

cdancy commented Aug 31, 2018

@richabindra nope that looks great and thanks for adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants