-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/expose modules for logging #157
Feature/expose modules for logging #157
Conversation
Code LGTM. Yeah not sure if you can just clone the wiki over or if it will come with the branch. @martinda do you remember how you did this? |
The documentation is on a different upstream, in this case it would be |
@richabindra Thank you for providing the wiki and the code. Regarding the Wiki, it will need to be updated after this PR makes it to a release in order for the examples to use the right version numbers. Also I suggest you run all the code in the examples to make sure they are accurate. |
Ran the code in the examples as @martinda suggested. The example was tested by setting the version of bitbucket-rest to 2.2.1-SNAPSHOT locally, and is published with version set to 2.2.1. |
@richabindra thanks for the PR! I can kick an new patch release ASAP if you want one. Just let me know. |
@cdancy - yes, a new patch release would be great! thank you :) |
@richabindra version |
@cdancy - thank you.. appreciate the quick response :) |
@richabindra you're welcome and no problem. |
@cdancy - I tried pushing wiki page directly to your repository, but I am getting permission denied (obviously, but I just wanted to try). How do you want to go about moving wiki to your space? |
@richabindra try again. I just opened things up to allow anyone to edit. |
@cdancy - done. thank you. I have added logging page to wiki. Please review and let me know if there is anything that needs to be fixed.. |
@richabindra nope that looks great and thanks for adding it. |
This PR addresses Issue #156. A module option is added to the builder, so logging can be added at the application level if needed.