Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepositoryApi: Listing all repos regardless of project ( copy of #191) #192

Merged
merged 4 commits into from
Apr 26, 2019

Conversation

mronus
Copy link
Contributor

@mronus mronus commented Apr 18, 2019

  • Update base path for RepositoryApi
  • Create a new endpoint in RepositoryApi to list all repositories regardless of project

closes #190

M. Abdullah Onus added 2 commits April 16, 2019 23:10
}
assertThat(found).isTrue();
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a live test to exercise the failure case. I guess you could put in say bogus values for things just to get bitbucket to return an error state. I do this for every endpoint so there should be multiple examples within this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review the last commit when you have time.

server.shutdown();
}
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here: lets add a live test to exercise the failure case. I guess you could put in say bogus values for things just to get bitbucket to return an error state. I do this for every endpoint so there should be multiple examples within this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review the last commit when you have time.

@cdancy cdancy self-assigned this Apr 18, 2019
@cdancy cdancy added this to the v2.5.3 milestone Apr 18, 2019
@cdancy cdancy merged commit cc0ee01 into cdancy:master Apr 26, 2019
@cdancy
Copy link
Owner

cdancy commented Apr 26, 2019

Thanks for the PR @mronus . Kicking a point release shortly.

@cdancy
Copy link
Owner

cdancy commented Apr 26, 2019

v2.5.3 has been released with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RepositoryApi: get all public/private repos together without looping projects
2 participants