238: Implement keys endpoints to list access keys

[dodie]

Hi @cdancy ,

This is a draft PR to implement the keys API endpoint discussed in #238 .
I've tested the new API manually, but I'm not finished with the automated tests yet.

I'm opening this draft PR, hoping to ask for feedback if I'm going to the right direction with the implementation:

• Is it okay to use the already existing AccessKey model objects for this endpoint? Semantically the new usecase uses them similarly as they are used in the already existing endpoint, but here we need a few additional optional parameters.
• Is it okay to not cover only a part of the Keys API? For my usecase, I only need querying and deleting access keys, but not creating and updating them.

Thanks,
David

[cdancy]

@dodie yeah it actually looks great so far! Can't spot anything off. Would just need mock and integTests for each of these new endpoints and we will be good to go.

[dodie]

Hi @cdancy ,

In the end I also created the endpoint methods for creating keys because they were needed in the integration tests.
I also added the mock and integration tests.

Please let me know if anything needs to be further aligned.

Also, I noticed that the build is now failing for an unrelated error, it seems that the InsightsApiLiveTest class has wrong formatting. Shall I fix that as well in this PR?

Cheers,
David

[cdancy]

Also, I noticed that the build is now failing for an unrelated error, it seems that the InsightsApiLiveTest class has wrong formatting. Shall I fix that as well in this PR?

@dodie yes if you don't mind :) I've got no complaints on the test side of things. When you're ready to move forward and merge just ping me here and I'll kick a new release. This looks really great and thanks!

[dodie]

@cdancy : I've added the missing formatting fixes, now the project builds successfully.
From my point of view, the KeysApi is ready to be released! 🚀

[cdancy]

@dodie 2.7.0 has been released and thanks again for the PR!

[dodie]

@cdancy 👍
Thank you for the quick release!