Add new endpoint build api #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdancy
reviewed
Apr 20, 2017
| /** | ||
| * Mock tests for the {@link BuildApi} class. | ||
| */ | ||
| @Test(groups = "unit", testName = "BranchApiMockTest") |
There was a problem hiding this comment.
Lets change testName to BuildApiMockTest
cdancy
reviewed
Apr 20, 2017
| @@ -59,4 +60,7 @@ | |||
|
|
|||
| @Delegate | |||
| AdminApi adminApi(); | |||
|
|
|||
| @Delegate | |||
| BuildApi buildApi(); | |||
There was a problem hiding this comment.
Lets rename to BuildStatusApi to better align with this http path.
|
@j0nathan33 looks good. One more minor comment to address and we should be good to go. |
|
I will need release for monday (may 1 2017) |
|
@j0nathan33 been a bit pre-occupied with our move to AWS/CBJ. I'll run the live tests now and merge if all is Ok then do another release. Stay tuned... |
|
Integration tests pass as expected. Thanks @j0nathan33 ! |
|
@j0nathan33 v0.0.15 has been released. FYI: massaged your last PR a bit so your local branch may be off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last change for this month. Go ahead for next release after accept my pull Request