Create/Delete permission group in repo

[j0nathan33]

No description provided.

[cdancy]

LGTM but will need some live tests before we can merge.

[cdancy]

This actually returns a 204 no content. Can we update the test to reflect as much as well as the mock test to set the correct return code?

[j0nathan33]

This test is good, because It try to create permission group with group don't existent. If group don't exist, Bitbucket return a 404 Not Found.

[cdancy]

One minor hiccup and I would like to see actual live tests that can succeed and work. Something like the below would suffice:

    @Test 
    public void testDeletePermissionByGroupNonExistent() {
        boolean success = api().deletePermissionsByGroup(projectKey, repoKey, "some-name");
        assertThat(success).isTrue();
    }
    
    @Test (dependsOnMethods = "testDeletePermissionByGroupNonExistent")
    public void testCreatePermissionByGroupNonExistent() {
        boolean success = api().createPermissionsByGroup(projectKey, repoKey, "REPO_WRITE", "some-name");
        assertThat(success).isTrue();
    }

[j0nathan33]

For me, default group in bitbucket is stash-users.

[cdancy]

For me, default group in bitbucket is stash-users.

@j0nathan33 yeah that works. One of these days we'll have to get a proper integration test flow going instead of this ad-hoc process I have now. That would be an awesome story/ISSUE to take on ;)

[cdancy]

In either event LGTM. Thanks @j0nathan33 !