Add possibility to get branch Model Condition #68
Conversation
…o branchModel-list # Conflicts: # src/main/java/com/cdancy/bitbucket/rest/fallbacks/BitbucketFallbacks.java
| @@ -0,0 +1,50 @@ | |||
| /* | |||
There was a problem hiding this comment.
Should this file be here? Doesn't seem to be used
There was a problem hiding this comment.
I use in another PR (#69).
| @AfterClass | ||
| public void fin() { | ||
| boolean success = api().updateDefault(projectKey, repoKey, defaultBranchId); | ||
| assertThat(success).isTrue(); | ||
| success = api().delete(projectKey, repoKey, "refs/heads/" + branchName); | ||
| assertThat(success).isTrue(); | ||
| if (branchModelConfiguration != null) { | ||
| checkDefaultBranchConfiguration(); |
There was a problem hiding this comment.
Do we need to do this check twice?
There was a problem hiding this comment.
Oops, This line is for update
| @Test(dependsOnMethods = {"testCreateBranch", "testListBranches"}) | ||
| public void testGetBranchModelConfiguration() { | ||
| branchModelConfiguration = api().getModelConfiguration(projectKey, repoKey); | ||
| checkDefaultBranchConfiguration(); |
There was a problem hiding this comment.
If we don't need to do this check twice than lets remove the checkDefaultBranchConfiguration method and instead add that code here.
There was a problem hiding this comment.
Seen you pushed a commit but missed this. Not sure if you were planning on addressing with a subsequent commit.
There was a problem hiding this comment.
If I remove it, I need to readd it in another PR (#69)
There was a problem hiding this comment.
Gotcha ... yeah looking at that PR now. Ok lets keep it then.
| @@ -17,17 +17,16 @@ | |||
|
|
|||
There was a problem hiding this comment.
Another LiveTest to check for errors? Maybe named something like testGetBranchModelConfigurationOnError()?
| private void checkDefaultBranchConfiguration() { | ||
| assertThat(branchModelConfiguration).isNotNull(); | ||
| assertThat(branchModelConfiguration.errors().isEmpty()).isTrue(); | ||
| assertThat(branchModelConfiguration.development().refId()).isNotNull(); |
No description provided.