debugging intermittent failures #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
debug_intermittent_issues
branch
from
147830c to
aad1327
Compare
GnsP
requested changes
Mar 26, 2024
| @@ -126,7 +126,8 @@ public static void waitTillConnectionDataLoadingCompletes(long timeoutInSeconds) | |||
| * Example : For GCS pass actual bucket name as parameter. | |||
| */ | |||
| private static void selectConnectionDataRow(String dataRow) { | |||
| waitTillConnectionDataLoadingCompletes(ConstantsUtil.DEFAULT_TIMEOUT_SECONDS); | |||
| // waitTillConnectionDataLoadingCompletes(ConstantsUtil.DEFAULT_TIMEOUT_SECONDS); | |||
| WaitHelper.waitForElementToBeClickable(CdfConnectionLocators.searchDirectoryInput, 120); | |||
There was a problem hiding this comment.
Please use a named constant instead of 120.
Also, please remove the commented line.
There was a problem hiding this comment.
Preferably use ConstantsUtil.DEFAULT_TIMEOUT_SECONDS which is 180.
AnkitCLI
force-pushed
the
debug_intermittent_issues
branch
from
aad1327 to
d8e1c98
Compare
GnsP
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to solve the intermittent issue in google cloud repo due to spinning indicator.