Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21096] Split Appfabric into stateless service and stateful processor #123

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vsethi09
Copy link
Contributor

@vsethi09 vsethi09 commented Dec 16, 2024

Context

Make appfabric service stateless by splitting it into appfabric service to server HTTP requests and appfabric processor to run subscriber services and process message.

Change Description

  • Upgrade from Golang 1.19 to 1.23 since:

    • Golang version 1.19 is out of support and version 1.23 is the latest available version.
    • Tests were failing as controller-runtime/tools/setup-envtest@latest is compatible with golang version 1.19.
    • Note: go.sum was generated by running go mod tidy.
  • CDAP master types:

    • Added new config for AppFabricProcessor of type AppFabricProcessorSpec. AppFabricProcessorSpec consists of stateful spec CDAPStatefulServiceSpec.
    • Changed spec for AppFabricSpec to stateless spec CDAPScalableServiceSpec.
  • deployment.go:

    • Changed type of appfabric service as k8s deployment.
    • Added appfabric processor of type k8s statefulset.
  • Auto-generated files:

    • api/v1alpha1/zz_generated.deepcopy.go
    • CRD: config/crd/bases/cdap.cdap.io_cdapmasters.yaml

Verification

  1. Tested using unit tests in golang by running make test.
  2. Deployed locally built cdap-operator image to a k8s cluster and verified by deployed CRD and CR.

@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch from 9bb3aa5 to 603ac0e Compare December 16, 2024 14:01
@vsethi09 vsethi09 marked this pull request as draft December 16, 2024 14:03
@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch 5 times, most recently from 90722fd to 0362c71 Compare December 16, 2024 14:58
@vsethi09 vsethi09 marked this pull request as ready for review December 16, 2024 16:11
@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch from 0362c71 to 5fd48eb Compare December 16, 2024 16:12
@vsethi09 vsethi09 changed the title Split Appfabric into stateless service and stateful processor [CDAP-21096] Split Appfabric into stateless service and stateful processor Dec 16, 2024
@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch from 5fd48eb to 24c51d3 Compare December 16, 2024 16:34
@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch from 24c51d3 to 903ec53 Compare December 16, 2024 18:02
@vsethi09 vsethi09 force-pushed the feature/CDAP-21096_split_appfabric_service_processor branch from 903ec53 to c877f2d Compare December 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants