Skip to content

Commit

Permalink
Merge pull request #1269 from cdapio/fix-github-action-build
Browse files Browse the repository at this point in the history
Fix github action to run on labeled event
  • Loading branch information
itsankit-google authored Dec 10, 2024
2 parents bf40ff0 + bcc424e commit 1bde3fd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 50 deletions.
20 changes: 15 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
branches: [ develop, release/** ]
pull_request:
branches: [ develop, release/** ]
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, labeled]
workflow_dispatch:
inputs:
branch:
Expand All @@ -32,11 +32,21 @@ jobs:

runs-on: k8s-runner-e2e

if: ${{ github.event.workflow_run.conclusion != 'skipped' }}
# We allow builds:
# 1) When it's a merge into a branch
# 2) For PRs that are labeled as build and
# - It's a code change
# - A build label was just added
# A bit complex, but prevents builds when other labels are manipulated
if: >
github.event_name == 'push'
|| (contains(github.event.pull_request.labels.*.name, 'build')
&& (github.event.action != 'labeled' || github.event.label.name == 'build')
)
steps:
# Pinned 1.0.0 version
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive

Expand All @@ -46,7 +56,7 @@ jobs:
with:
node-version: 22.12

- uses: actions/cache@v3.3.0
- uses: actions/cache@v4
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
Expand Down Expand Up @@ -99,7 +109,7 @@ jobs:
mvn clean verify -P e2e-tests -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
- name: Archive build artifacts
uses: actions/upload-artifact@v3.1.2
uses: actions/upload-artifact@v4
if: always()
with:
name: Build debug files
Expand Down
45 changes: 0 additions & 45 deletions .github/workflows/trigger.yml

This file was deleted.

0 comments on commit 1bde3fd

Please sign in to comment.