-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry pick [CDAP-20804] into release 6.9 #1112
Conversation
[CDAP-20804] : Fix tink directive add for replication transformations
@@ -54,6 +54,7 @@ Feature: Wrangler Spanner Tests | |||
Then Verify URL navigation | |||
|
|||
@WRANGLER_SPANNER_TEST | |||
@ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test breaking in this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njbriggs i figured it was a flaky test everywhere? @sumengwang ?
also we have this failure Non-resolvable parent POM for io.cdap.cdap:cdap-ui:6.9.3: Could not find artifact io.cdap.cdap:cdap:pom:6.9.3 in sonatype (https://oss.sonatype.org/content/groups/public) and 'parent.relativePath' points at wrong local POM @ line 23, column 11 -> [Help 2]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing a -SNAPSHOT
somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe 6.9.3 https://github.com/cdapio/cdap-build/releases/tag/v6.9.3 was created after this test triggering. I'm rerunning it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you disabling the spanner test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that test is super flaky in dev @sumengwang why would it be less flaky here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, didn't see it's already ignored in develop
pom.xml
Outdated
@@ -23,7 +23,7 @@ | |||
<parent> | |||
<groupId>io.cdap.cdap</groupId> | |||
<artifactId>cdap</artifactId> | |||
<version>6.9.3</version> | |||
<version>6.9.4</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-SNAPSHOT
CDAP-20804 : Fix tink directive add for replication transformations
cherry pick 20804 into release 6.9
Description
Summary of changes
PR Type