Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version as CDAP UI builds are failing with incompatible node version error #1265

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

radhikav1
Copy link
Collaborator

@radhikav1 radhikav1 commented Dec 5, 2024

CDAP UI builds are failing with incompatible node version error

Description

Summary of changes

PR Type

  • Bug Fix
  • Feature
  • Build Fix
  • Testing
  • General Improvement
  • Cherry Pick

Links

Jira: CDAP-21088

Test Plan

Build & tests should be successful.

Screenshots

n/A

@njbriggs
Copy link
Collaborator

njbriggs commented Dec 5, 2024

Node 18 is already in maintenance state and will be deprecated in mid-2025 - see https://nodejs.org/en/about/previous-releases. Since we're making this change, we should go to 22 for the longest support window.

@GnsP
Copy link
Collaborator

GnsP commented Dec 5, 2024

Updating the node version in the frontend-maven-plugin may not be the complete fix (please check). I think this plugin is used in the build step only. We should also upgrade the node version used in the ui-image (in the deployments).

@radhikav1 radhikav1 force-pushed the upgrade-node-version branch from 6ecb47d to 66c77e2 Compare December 6, 2024 04:35
@radhikav1
Copy link
Collaborator Author

Node 18 is already in maintenance state and will be deprecated in mid-2025 - see https://nodejs.org/en/about/previous-releases. Since we're making this change, we should go to 22 for the longest support window.

Got it, Thanks Nick. Updated to 22 version.

@radhikav1 radhikav1 force-pushed the upgrade-node-version branch 2 times, most recently from bb5d736 to 9f0661c Compare December 6, 2024 05:55
@radhikav1
Copy link
Collaborator Author

Updating the node version in the frontend-maven-plugin may not be the complete fix (please check). I think this plugin is used in the build step only. We should also upgrade the node version used in the ui-image (in the deployments).

Updated node version in the build.yml as well.

@radhikav1 radhikav1 requested a review from GnsP December 6, 2024 07:55
@itsankit-google itsankit-google force-pushed the upgrade-node-version branch 4 times, most recently from d828040 to 0b0e35c Compare December 6, 2024 12:59
@itsankit-google itsankit-google merged commit 08eeaad into develop Dec 7, 2024
6 checks passed
@itsankit-google itsankit-google deleted the upgrade-node-version branch December 7, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants