Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build,parseApi): minor syntax updates #190

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Conversation

cdcabrera
Copy link
Owner

What's included

  • refactor(build,parseApi): minor syntax updates

Notes

  • minor syntax, prep for v5.0.0

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

...

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added the refactor no quite performance, not quite broken, just different label Nov 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #190 (7e24bfa) into main (4cb87ab) will increase coverage by 0.87%.
The diff coverage is 58.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   70.61%   71.48%   +0.87%     
==========================================
  Files           5        5              
  Lines         245      242       -3     
  Branches       91       91              
==========================================
  Hits          173      173              
+ Misses         62       60       -2     
+ Partials       10        9       -1     
Impacted Files Coverage Δ
src/api/buildApi.js 50.00% <23.07%> (+2.94%) ⬆️
src/api/parseApi.js 75.96% <82.35%> (-0.23%) ⬇️
src/docs/buildDocs.js 87.50% <100.00%> (ø)
src/index.js 79.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb87ab...7e24bfa. Read the comment docs.

@cdcabrera cdcabrera merged commit 331b0a0 into main Nov 5, 2022
@cdcabrera cdcabrera deleted the 20221015-dev branch March 8, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor no quite performance, not quite broken, just different
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants