Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load masks from colmap-style output directory in DensifyPointCloud #1011

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dllu
Copy link
Contributor

@dllu dllu commented Jun 19, 2023

Loads masks from an arbitrary folder.

@cdcseacave cdcseacave self-requested a review June 20, 2023 09:05
Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, but instead of adding support for importing masks in each interface, why not use instead the --mask-path <folder> functionality already existing in DensifyPointcloud which does exactly this?

@ghost
Copy link

ghost commented Jun 23, 2023

I think it's nice as well but since colmap doesn't natively undistort masks, the image extension can be renamed to .mask.png in a script to work with --mask-path, dllu.

@cdcseacave
Copy link
Owner

if that is true (colmap does no undistort the masks as well) then this change make even less sense: even if imported in MVS they will be wrongly used; so the only way to make this happen is a script using colmap and the undistoreted scene params that undistorts the masks (as at the interface point the scene does not have this information anymore), and in the process can also make sure they follow the OpenMVS file naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants