Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine: robustify computation of refinement regularization scale #811

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adelpit
Copy link
Contributor

@adelpit adelpit commented Apr 19, 2022

  • Use the masked depth map for the distance calculation so it will consider only the content inside the user-defined region of interest
  • Use the average of the inverse depth (harmonic mean of depth) so that the metric scales with parallax rather than depth. This will also have the benefit of increase the influence of near structures

146418653-1e6c9197-61c6-47bd-8856-c72f097f14eb

Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew, these days I had time to look over this PR, and I like the idea you are suggesting. However I was wondering if instead of computing a RegularizationScale for the entire image, would be better (in the same spirit of the idea) to compute it per pixel (or per triangle) like:

pixelRegularizationScale = SQUARE(depth / cameraA.GetFocalLength())

Hopefully this will be not only better, but cheaper to compute as we will not need to compute ComputeAverageLocalInverseDepth()

Did you try this already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants