Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add COLMAP SfM to MvgMvsPipeline.py #977

Merged
merged 2 commits into from Apr 28, 2023
Merged

common: add COLMAP SfM to MvgMvsPipeline.py #977

merged 2 commits into from Apr 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2023

  • Added steps for COLMAP SfM

@ghost ghost changed the title common: add COLMAP SfM to pipeline script common: add COLMAP SfM to MvgMvsPipeline.py Apr 21, 2023
Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you!

13. Exhaustive Matcher colmap
14. Mapper colmap
15. Image Undistorter colmap
16. Export to openMVS interfaceCOLMAP
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be capital I
InterfaceCOLMAP

@@ -21,19 +22,24 @@
2. Compute pairs openMVG_main_PairGenerator
3. Compute matches openMVG_main_ComputeMatches
4. Filter matches openMVG_main_GeometricFilter
5. Incremental reconstruction openMVG_main_IncrementalSfM
6. Global reconstruction openMVG_main_GlobalSfM
5. Incremental reconstruction openMVG_main_SfM
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this changed in latest OpenMVG?

Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the windows version

@cdcseacave cdcseacave merged commit 285de9b into cdcseacave:develop Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant