Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of Char literals #57

Merged
merged 3 commits into from
Dec 21, 2019
Merged

Fix handling of Char literals #57

merged 3 commits into from
Dec 21, 2019

Conversation

sjakobi
Copy link
Contributor

@sjakobi sjakobi commented Dec 12, 2019

Fixes #45.

@cdepillabout
Copy link
Owner

I only did a quick skim over this, but it looks pretty good! Give me a week or so to do a thorough review of this.

@cdepillabout
Copy link
Owner

@sjakobi Sorry for making you wait for this.

In 0b95aec I added some tests and fixed up a small problem with parsing other characters.

@cdepillabout cdepillabout merged commit 6c842d7 into cdepillabout:master Dec 21, 2019
@cdepillabout
Copy link
Owner

Bumped version and released to hackage:

https://hackage.haskell.org/package/pretty-simple-3.2.0.0

@sjakobi sjakobi deleted the 45-char branch December 21, 2019 14:17
@sjakobi
Copy link
Contributor Author

sjakobi commented Dec 21, 2019

No worries and many thanks! :)

@cdepillabout cdepillabout mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the parser doesn't understand Haskell characters like 'a'
2 participants
@sjakobi @cdepillabout