Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespaces from the end of lines #62

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

ghallak
Copy link
Contributor

@ghallak ghallak commented Jan 25, 2020

Closes: #61

@cdepillabout
Copy link
Owner

@ghallak Thanks for trying to fix this.

It looks like CI is now failing on some of the doctests with this improvement. Could you fix these up?

https://travis-ci.org/cdepillabout/pretty-simple/jobs/641713245#L468

@ghallak
Copy link
Contributor Author

ghallak commented Jan 25, 2020

I have fixed the doctests expectations and squashed the commits. The CI checks are passing now.

@cdepillabout
Copy link
Owner

Looks good to me. Thanks!

@cdepillabout cdepillabout merged commit b15a485 into cdepillabout:master Jan 26, 2020
@cdepillabout
Copy link
Owner

@ghallak I wasn't planning on creating a Hackage release for this feature, but if you'd like one, please let me know!

@ghallak
Copy link
Contributor Author

ghallak commented Jan 26, 2020

I think it's fine without a Hackage release for this feature, the fixed issue was not causing the biggest problems.

@asr
Copy link

asr commented Feb 22, 2020

I would appreciate a Hackage release including this feature.

@cdepillabout
Copy link
Owner

No problem, released pretty-simple-3.2.2.0:

https://hackage.haskell.org/package/pretty-simple-3.2.2.0

@asr
Copy link

asr commented Feb 23, 2020

Great! Thanks!

@georgefst georgefst mentioned this pull request Mar 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing whitespace
3 participants