Fix foreground and background colors #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dakotaclemenceplaza Could you try this out on your machine and make sure you're still able to set the foreground and background colors properly? I just want to make sure this PR is working as well as you have #110 working. |
|
@cdepillabout Everything works as expected. |
This was referenced Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in #29 with not being able to set the background color for a terminal if the palette was set.
In #110, @dakotaclemenceplaza figured out that this was caused by not setting any value for the alpha channel of an RGBA color.
This PR uses the fix from #110 and simplifies some of the logic for setting colors.
Fixes #29