Preferences file #140
Merged
Preferences file #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user closes the preferences window, termonad saves the changes to the preferences file.
|
@jecaro Thanks! Give me a couple days to look over this. |
|
@jecaro Thanks, I finally got a chance to look this over. It looks pretty good to me. I made a few small changes (mostly just moving stuff around and adding a warning to the termonad.yaml file). Could you do a review of the commits I added? Once you sign off on this, I'll merge this in and cut a release to Hackage. |
|
Putting these functions in a separate file makes it nice and tidy. I just add a commit with minor changes in comments and documentation. Despite that it looks good to me. |
|
@jecaro Thanks for fixing stuff! Released to Hackage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic preferences file #133. It basically works as described here.
A few things about this:
FromJSONandToJSONinstances forGI.Vte.Enums.CursorBlinkModeare orphan. If needed I can wrap it in a newtype.