Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Github-CDEvents Integration #47

Merged
merged 10 commits into from
Feb 26, 2025
Merged

Conversation

rjtch
Copy link
Contributor

@rjtch rjtch commented Oct 4, 2024

This RFC describes

an approach to integrate Jira with CDEvents using using webhook-adapter.
and the list of Github-Webhook event types mapping with CDEvents.

This RFC is related to this task cd-event-github-plugin

rjtch added 2 commits October 2, 2024 23:07
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I left a few comments.
Let me know what you think. The idea in cdevents/webhook-adapter#2 is to create a plugin for the existing webhook adapter, not to create a new one. You could use the existing gerrit plugin as a starting point: https://github.com/cdevents/gerrit-translator/

Signed-off-by: airghy <tchuinkoufongue@gmail.com>
@rjtch
Copy link
Contributor Author

rjtch commented Nov 24, 2024

Thanks for this, I left a few comments. Let me know what you think. The idea in cdevents/webhook-adapter#2 is to create a plugin for the existing webhook adapter, not to create a new one. You could use the existing gerrit plugin as a starting point: https://github.com/cdevents/gerrit-translator/

@afrittoli i have just modified the PR and tried to modify and simplify it as i could and got inspired by the https://github.com/cdevents/gerrit-translator/. Let me know what you think about. This could be a good starting point.

@rjtch rjtch requested a review from afrittoli December 5, 2024 14:39
Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I left a few comments, but generally it looks good.
Looking forward to see this implemented!
I went ahead and created the repo: https://github.com/cdevents/github-translator

@xibz FYI

Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
rjtch and others added 3 commits December 11, 2024 10:42
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates.
@xibz ok to merge?

Signed-off-by: airghy <tchuinkoufongue@gmail.com>
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I like just removing it since it necessarily isn't the end of the world if we dont have it.

@xibz
Copy link
Contributor

xibz commented Feb 25, 2025

@afrittoli This is good to be merged, from my point of view

@afrittoli afrittoli merged commit afd6562 into cdevents:main Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants