Skip to content

Commit

Permalink
Repo optional in branch and change schemas
Browse files Browse the repository at this point in the history
The repository is an optional field in branch and change events,
both in the specification as well as in the SDK.

This is because the source includes the repository information already.
While there is value in specifying the repository reference separated
from the SCM system URL, it should not be mandatory to do so.

The schema files for branch and change events specify the repository
as a mandatory field. This was an oversight, which is fixed here.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
  • Loading branch information
afrittoli committed Oct 25, 2022
1 parent 4d97242 commit fef9b84
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 28 deletions.
5 changes: 1 addition & 4 deletions schemas/branchcreated.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/branchdeleted.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/changeabandoned.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/changecreated.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/changemerged.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/changereviewed.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down
5 changes: 1 addition & 4 deletions schemas/changeupdated.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,7 @@
}
},
"additionalProperties": false,
"type": "object",
"required": [
"repository"
]
"type": "object"
}
},
"additionalProperties": false,
Expand Down

0 comments on commit fef9b84

Please sign in to comment.