Sets expectations for testcaserun predicates #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olensmar
approved these changes
Jun 27, 2023
afrittoli
reviewed
Jul 31, 2023
afrittoli
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Thanks @dan-han-101 - this makes sense to me.
I guess we should merge the PR that adds "skip" first?
|
Sure, we can wait for the other PR to complete first |
dan-han-101
force-pushed
the
testcase.guidelines
branch
from
58901da to
868eae6
Compare
The documentation update sets expecations on the sequence of expected test events. This update was triggered by discussions in cdevents#140 Signed-off-by: Daniel Han <dhan17@bloomberg.net>
Co-authored-by: Emil Bäckmark <emil.backmark@ericsson.com> Signed-off-by: Daniel Han <dhan17@bloomberg.net>
The 'skip' outcome is being added in cdevents#145, so we'll update this document assuming that this outcome will exist Signed-off-by: Daniel Han <dhan17@bloomberg.net>
fix spelling mistake Signed-off-by: Daniel Han <dhan17@bloomberg.net>
dan-han-101
force-pushed
the
testcase.guidelines
branch
from
868eae6 to
0a12cd0
Compare
|
FYI - my previous commits were failing the DCO checks. In order to fix them, I had to do a force push where I updated the author email to be more consistent, and then added the sign off message in each commit. |
4 tasks
|
Closing this one, in favor of https://github.com/cdevents/spec/pull/145/files . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The documentation update sets expecations on the sequence of expected test events.
This update was triggered by discussions in
#140
Submitter Checklist
As the author of this PR, please check off the items in this checklist: