Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom events type #185

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Custom events type #185

merged 3 commits into from
Mar 13, 2024

Conversation

afrittoli
Copy link
Contributor

Changes

Add support for CDEvents custom events

As previously discussed in https://hackmd.io/LftfRirGRbKuAcLg9pdOag,
this introduces support for custom events:

  • add a schemaURI (Add an optional schemaUri to the context #184)
  • add dev.cdeventsx types in spec.md
  • add a custom folder which includes
    • README.md with context about custom events
    • registry.md to register external specs
    • schema.json - a common schema for custom events

Fixes: #168

Signed-off-by: Andrea Frittoli

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

@afrittoli afrittoli requested a review from a team as a code owner February 22, 2024 15:06
@afrittoli afrittoli force-pushed the custom_events_type branch 4 times, most recently from b159c29 to 7aa7f37 Compare February 22, 2024 15:33
@afrittoli afrittoli added this to the v0.5 milestone Mar 4, 2024
@afrittoli afrittoli force-pushed the custom_events_type branch 2 times, most recently from 05faf59 to 3422cf6 Compare March 6, 2024 13:00
@afrittoli afrittoli modified the milestones: v0.5, v0.4 Mar 12, 2024
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Add schemaURI to the context. It can be used to link to
a custom schema that further refines the event content.

Context:
- cdevents#168
- cdevents#91

Fixes: cdevents#91

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
As previously discussed in https://hackmd.io/LftfRirGRbKuAcLg9pdOag,
this introduces support for custom events:

- add a schemaUri (cdevents#184)
- add dev.cdeventsx types in spec.md
- add a custom folder which includes
  - README.md with context about custom events
  - registry.md to register external specs
  - schema.json - a common schema for custom events

Fixes: cdevents#168

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli force-pushed the custom_events_type branch from 63bcf43 to 3694a95 Compare March 13, 2024 10:45
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli force-pushed the custom_events_type branch from 3694a95 to 3f714fa Compare March 13, 2024 10:51
@afrittoli afrittoli merged commit 87c9290 into cdevents:main Mar 13, 2024
4 checks passed
@afrittoli afrittoli mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event type extensions for adopting tools
3 participants