-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom events type #185
Merged
Merged
Custom events type #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b159c29
to
7aa7f37
Compare
05faf59
to
3422cf6
Compare
xibz
reviewed
Mar 7, 2024
e-backmark-ericsson
requested changes
Mar 11, 2024
e-backmark-ericsson
approved these changes
Mar 12, 2024
xibz
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Add schemaURI to the context. It can be used to link to a custom schema that further refines the event content. Context: - cdevents#168 - cdevents#91 Fixes: cdevents#91 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
As previously discussed in https://hackmd.io/LftfRirGRbKuAcLg9pdOag, this introduces support for custom events: - add a schemaUri (cdevents#184) - add dev.cdeventsx types in spec.md - add a custom folder which includes - README.md with context about custom events - registry.md to register external specs - schema.json - a common schema for custom events Fixes: cdevents#168 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
63bcf43
to
3694a95
Compare
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
3694a95
to
3f714fa
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for CDEvents custom events
As previously discussed in https://hackmd.io/LftfRirGRbKuAcLg9pdOag,
this introduces support for custom events:
Fixes: #168
Signed-off-by: Andrea Frittoli
Submitter Checklist
As the author of this PR, please check off the items in this checklist: