-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain relations to CloudEvents #19
Conversation
@erkist Was it you who pinned the text during that meeting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looking good, only a couple of comments.
primer.md
Outdated
- [Acknowledgments](#acknowledgments) | ||
<!-- /toc --> | ||
|
||
## History | ||
|
||
TBD | ||
|
||
## Relations to CloudEvents | ||
|
||
CDEvents defines a specification that provides a set of JSON object schemas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: extra space before "that"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps "specification" could be a link to cloudevents-binding.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bea4bbe
I looks like GitHub does not like your commit signature for some reason. I use GPG to sign my comments, S/MIME is another option: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. I enabled signature for commits and use security features available out of the box - but I'd be happy to disable it if it becomes too much of an hassle. |
Signed-off-by: Mattias Linnér <mattias.linner@ericsson.com>
Signed-off-by: Mattias Linnér <mattias.linner@ericsson.com>
f33778f
to
bea4bbe
Compare
I didn't sign before but now that is fixed. Lets see what others think |
We don't really have a policy about number of reviews before merging - since this was already discussed in previous meetings, it should be safe to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @m-linner-ericsson, it looks good!
This amendment to the primer aims to explain the relations between CDEvents and CloudEvents. Reworded version of SIG Events meeting note from 19th of October 2021.
Signed-off-by: Mattias Linnér mattias.linner@ericsson.com