Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $id of schema testsuiterunfinished #190

Merged

Conversation

davidB
Copy link
Contributor

@davidB davidB commented Mar 7, 2024

Changes

align $id of schema testsuiterunfinished with subject value

FIX #186

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

@davidB davidB requested a review from a team as a code owner March 7, 2024 19:06
Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@afrittoli
Copy link
Contributor

@davidB I just realised that your commit is not signed. Could you fix that please so we can merge this PR?

@davidB davidB force-pushed the fix_id_of_schema_testsuiterunfinished branch from 71d0c18 to a33cc57 Compare March 16, 2024 15:35
FIX cdevents#186

Signed-off-by: David Bernard <david.bernard.31@gmail.com>
@davidB davidB force-pushed the fix_id_of_schema_testsuiterunfinished branch from a33cc57 to 70fca63 Compare March 16, 2024 15:42
@davidB
Copy link
Contributor Author

davidB commented Mar 16, 2024

@afrittoli, Sorry I guessed sign-off was enough.
fixed

@afrittoli afrittoli merged commit 96fd5f2 into cdevents:main Mar 16, 2024
4 checks passed
@afrittoli afrittoli added this to the v0.4 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix $id of schema testsuiterunfinished
4 participants