Validate jsonschemas and fix them accordingly #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
force-pushed
the
check_jsonschemas
branch
8 times, most recently
from
f806d6f to
152d3f0
Compare
Add validation of jsonschemas to our CI. The links and embeddedlinks schemas where invalid, as well as the references to them from the event schemas, so fixing all those to let CI pass. Switch to ajv for example validation, which allows for validation of both JSON documents as well as schemas. ajv let users load references schemas from files into the tool offline databases, which enables offline validation of unpublished schemas. Since ajv is javascript, update the GitHub action workflow to javascript. Fixes: cdevents#208 Fixes: cdevents#211 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Since all references to the link schemas have been updated, we need
to bump all event versions too.
This as usual is automated:
ls examples | while read aa; do sp="$(echo ${aa%.*} | tr "_" ".")"; ./tools/event-version.sh -u $sp -s; done
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
afrittoli
force-pushed
the
check_jsonschemas
branch
from
152d3f0 to
7d138a9
Compare
afrittoli
changed the title
4 tasks
xibz
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Commit 1: Validate schemas and fix them accordingly
Add validation of jsonschemas to our CI.
The links and embeddedlinks schemas where invalid,
as well as the references to them from the event
schemas, so fixing all those to let CI pass.
Switch to ajv for example validation, which allows for
validation of both JSON documents as well as schemas.
ajv let users load references schemas from files into
the tool offline databases, which enables offline
validation of unpublished schemas.
Since ajv is javascript, update the GitHub action
workflow to javascript.
Fixes: #208
Fixes: #209
Fixes: #211
Commit 2: Bump all event versions
Since all references to the link schemas have been updated, we need
to bump all event versions too.
This as usual is automated:
ls examples | while read aa; do sp="$(echo ${aa%.*} | tr "_" ".")"; ./tools/event-version.sh -u $sp -s; doneSubmitter Checklist
As the author of this PR, please check off the items in this checklist: