Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples to conformance #225

Merged
merged 1 commit into from
May 15, 2024

Conversation

afrittoli
Copy link
Contributor

@afrittoli afrittoli commented May 14, 2024

Changes

Examples are used for verification and SDK conformance purposes, so rename them to a more appropriate name.

Add a README that clarifies the role of these files. They can be used as a reference, values are valid but they are not meant to be particularly meaningful.

Fixes #217

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

@afrittoli afrittoli requested a review from a team as a code owner May 14, 2024 09:31
@afrittoli afrittoli added this to the v0.4 milestone May 14, 2024
@afrittoli afrittoli force-pushed the examples2conformance branch from 13dca3a to b1ced96 Compare May 15, 2024 09:30
Examples are used for verification and SDK conformance purposes,
so rename them to a more appropriate name.

Add a README that clarifies the role of these files. They can be
used as a reference, values are valid but they are not meant to
be particularly meaningful.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢

@afrittoli afrittoli merged commit 60c9534 into cdevents:spec-v0.4 May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants