Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import draft spec #5

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Import draft spec #5

merged 2 commits into from
Dec 16, 2021

Conversation

afrittoli
Copy link
Contributor

@afrittoli afrittoli commented Nov 30, 2021

Import the draft spec as-is from github.com/cdfoundation/sig-events,
except for minor lint and spelling fixes.

Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com

Import the draft spec as-is from github.com/cdfoundation/sig-events,
except for minor lint and spelling fixes.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Copy link
Contributor

@m-linner-ericsson m-linner-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should have been a change request

Copy link
Contributor

@m-linner-ericsson m-linner-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think the README.md should be updated with the following content:

# CDEvents

We are working on a draft version of our specification that is not yet ready for implementation. For more information check out our [spec](./spec.md)

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli
Copy link
Contributor Author

Looks good but I think the README.md should be updated with the following content:

# CDEvents

We are working on a draft version of our specification that is not yet ready for implementation. For more information check out our [spec](./spec.md)

Thank you @m-linner-ericsson - good catch, I added this now.

@afrittoli afrittoli merged commit 2de0e48 into cdevents:main Dec 16, 2021
@xibz xibz mentioned this pull request Aug 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants